DSP: Convert Mailbox enum into an enum class #9384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids implicit conversions and also prevents dumping identifiers into the current namespace.
These aren't used externally anywhere and can be made private.
Makes the array strongly typed and prevents pointer decay. This also allows for tuning bounds checks with various implementations.
leoetlino
approved these changes
Dec 29, 2020
iwubcode
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Avoids implicit conversions and also prevents dumping identifiers into the current namespace.
While we're at it, we can make the mailbox members private, given they aren't accessed externally