Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set console's default language/country/region based on computer settings #9388

Merged
merged 2 commits into from Apr 6, 2021

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Dec 29, 2020

Marking as a draft until PR #9571 is merged, to ensure that this doesn't cause any nasty desyncs for netplay and movies. Ready for review otherwise.

Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Show resolved Hide resolved
Source/Core/Core/Config/DefaultLocale.cpp Outdated Show resolved Hide resolved
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine, and this works correctly on Linux.

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booted up and it seemed to pick the correct settings on Windows. Code seems fine.

@leoetlino leoetlino marked this pull request as ready for review March 27, 2021 00:40
@leoetlino
Copy link
Member

Looks like a rebase is required

@leoetlino leoetlino merged commit e89ae71 into dolphin-emu:master Apr 6, 2021
10 checks passed
@JosJuice JosJuice deleted the default-locale branch April 6, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants