move the decision to delay raw memcard flushes out of the thread. #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,4 +35,6 @@ class MemoryCard : public MemoryCardBase | |||
| Common::Event m_flush_trigger; | |||
| Common::Flag m_is_exiting; | |||
| std::unique_ptr<u8[]> m_flush_buffer; | |||
| std::chrono::steady_clock::time_point m_last_flush; | |||
| static const std::chrono::seconds m_flush_interval; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This allows the flush to work better with games which hammer memcard accesses over short periods as it delays more of the work.
|
@shuffle2: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. LGTM, except for that small change. @dolphin-emu-bot allowmerge |
shuffle2
added a commit
that referenced
this pull request
Sep 2, 2014
move the decision to delay raw memcard flushes out of the thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the flush to work better with games which hammer
memcard accesses over short periods as it delays more of the work.