SysConf: Make use of std::string_view #9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
changed the title
leoetlino
approved these changes
Dec 29, 2020
leoetlino
reviewed
Dec 29, 2020
We can allow strings to be used with the SysConf interface in potentially non-allocating manners.
Allows GetOrAddEntry() to be implemented in a manner that doesn't result in a redundant lookup in the event an addition needs to be made.
Allows code to move into the constructor, avoiding copies entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allows strings to be used in potentially non-allocating manners.