JitArm64_RegCache: Interface cleanup #9396
Merged
+319
−285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents namespace pollution and makes the enum members strongly typed. This also mirrors the x64 variant as well.
Same behavior, but in-place initializes all values and makes it visually explicit at the declaration site.
Also provides operator!= for logical symmetry. We can also take the arguments by value, as the arguments are trivially copyable enum values which fit nicely into registers already.
Also moves comments to make for less wonky formatting.
Many of these don't modify member state, so they can be marked as const.
Avoids polluting the namespace and makes the members of the enumeration strongly typed.
BhaaLseN
approved these changes
Dec 30, 2020
leoetlino
approved these changes
Jan 1, 2021
There was a problem hiding this comment.
The REG_REG thing seems to be an oversight... It was added as part of bcde1aa#diff-bc54c6351f0ce20b932a4aa98992e19a69cdc5c55d5be79f839b25c8bf4b6d7cL132 which changed a lot of fpr.R(..., false); to fpr.R(..., REG_REG);. I bet it's a find-and-replace error :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Tidies up the interface in various minor ways, such as:
Converting the RegType enum over to an enum class in particular uncovered an odd quirk in two places. RegType enum members were being passed as the second argument to
BindToRegisterhere and here which is very unusual, as the second member ofBindToRegisteris abool, not aRegType, which seems pretty sketchy. I don't know if this is an actual bug rather than identifiers being abused however, so I'd appreciate input on that.