Arm64Emitter: Interface cleanup #9402
Merged
+200
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows eliminating some out variables in favor of optional, which allows narrowing visible scope of variables.
Silences warnings and makes intent explicit.
Eliminates some magic numbers and makes the type member strongly typed.
Avoids polluting the namespace and makes the members strongly typed.
Prevents namespace pollution and enforces strong typing.
Prevents namespace pollution and makes the enum members strongly typed.
Prevents namespace pollution and makes the enum members strongly typed.
Reduces namespace pollution and makes the enum strongly typed.
Allows for more concise code.
leoetlino
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Tidies up the interface a little by annotating switch fallthrough to avoid warnings. While we're at it we can convert quite a few enums into enum classes to prevent polluting namespaces and making their usage strongly typed.