Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and code coding conventions #9404

Merged
merged 3 commits into from Jan 5, 2021
Merged

Fix typos and code coding conventions #9404

merged 3 commits into from Jan 5, 2021

Conversation

Filoppi
Copy link
Contributor

@Filoppi Filoppi commented Dec 31, 2020

and removed some unused includes.

jordan-woyak
jordan-woyak requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@jordan-woyak jordan-woyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have two typos in your commit messages. "convenctions" and "convections".

@Filoppi
Copy link
Contributor Author

Filoppi commented Dec 31, 2020

You have two typos in your commit messages. "convenctions" and "convections".

Meta. It was a test.
Guess that doesn't matter though?

@jordan-woyak
Copy link
Member

You have two typos in your commit messages. "convenctions" and "convections".

Meta. It was a test.
Guess that doesn't matter though?

It matters as much as the typos you fixed. :/
Use git rebase -i upstream/master
then you can use "reword" to change the messages.

@Filoppi
Copy link
Contributor Author

Filoppi commented Jan 1, 2021

Fixed

@Filoppi @leoetlino
Core: Fix variable naming conventions
3acd172 
[committer note: squashed two commits]
@Filoppi @leoetlino
DolphinQt: Remove some useless includes
0805b58 
[committer note: fixed commit message style]
@Filoppi @leoetlino
Fix a couple of typos
a5a6ef8 
[committer note: fixed commit message style]
@leoetlino leoetlino merged commit e48377d into dolphin-emu:master Jan 5, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-woyak jordan-woyak jordan-woyak approved these changes

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Filoppi @jordan-woyak @Pokechu22 @leoetlino