Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Use Fullscreen" setting to "Start in Fullscreen" #9405

Merged
merged 1 commit into from Jan 6, 2021

Conversation

Filoppi
Copy link
Contributor

@Filoppi Filoppi commented Dec 31, 2020

The name was confusing as changing it at runtime would not change the window to fullscreen, as it effectively only affects the start of the emulation.
Also blocked the ability to change it when the emulation is running, to be more inline with other similar settings, like "Render to main Window".

The name was confusing as changing it at runtime would not change the window to fullscreen, as it effectively only affects the start of the emulation.
Also blocked the ability to change it when the emulation is running, to be more inline with other similar settings, like "Render to main Window".
@Rumi-Larry
Copy link

Rumi-Larry commented Jan 1, 2021

Hmm, why not make it so the setting changes the window? I assume it's not technically viable, given that one can always use the key combo.

@Filoppi
Copy link
Contributor Author

Filoppi commented Jan 1, 2021

Hmm, why not make it so the setting changes the window? I assume it's not technically viable, given that one can always use the key combo.

I don't know, I don't like the idea of making a window that isn't the active/focused one fullscreen when you press a button in another window. Also it just seems unnecessary, we already have the hotkey, users should use that (if they don't know how to enter fullscreen, they wouldn't know how to exit it).

@MayImilae
Copy link
Contributor

I'm pretty happy with this change.

So, we got the "Use Fullscreen" language from games, cause well, that's how they put it. However, it isn't that great of a fit for us. In games, the button is just, check mark it to make it fullscreen, uncheck it to make it windowed. That's it. But for us, it's way more complex, since we have a separate interface and main window and the render window can go in and out of fullscreen at any time with hotkeys or the button in the interface.

"Start in Fullscreen" is a much better way to phrase it for us, since well, that's how it works in Dolphin! Also, greying it out after emulation has started is good too, especially thanks to the increase clarity of the naming.

So yea, this is great!

@leoetlino leoetlino merged commit 0b1db65 into dolphin-emu:master Jan 6, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants