InputCommon: Wrap remaining invalid default input expressions around `` #9416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Jan 2, 2021
jordan-woyak
reviewed
Jan 2, 2021
Filoppi
force-pushed
the
patch-9
branch
2 times, most recently
from
15f2786
to
0e71e23
Compare
|
The lint check makes no sense IMO and it's not on failing on lines I changed. |
|
You did change those lines. (Either that or your local clang-format changed the lines, but I think it's been a while since I last saw the buildbot's clang-format disagree with someone's local clang-format.) Not sure why clang-format actually wants you to change those lines, but you'll have to indulge it. |
|
Yes I changed the lines trying to fix them after the first lint check failed, and then got the same error again because the fix it was asking for wasn't the one I expected. |
jordan-woyak
approved these changes
Jan 17, 2021
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
leoetlino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Otherwise they give an error when clicking ok if trying to view or edit the input expressions.
These should be the last ones left that had not been converted yet.