Fix FPS counter and Game Window speed % breaking on pause/unpause #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
changed the title
lioncash
reviewed
Jan 2, 2021
lioncash
reviewed
Jan 2, 2021
iwubcode
reviewed
Jan 2, 2021
iwubcode
reviewed
Jan 2, 2021
Filoppi
force-pushed
the
input-1
branch
2 times, most recently
from
1f0cb2f
to
27c1486
Compare
jordan-woyak
reviewed
Jan 3, 2021
Filoppi
force-pushed
the
input-1
branch
2 times, most recently
from
3577851
to
7b8051d
Compare
Filoppi
changed the title
|
@dolphin-emu-bot rebuild |
|
Not sure about the FIFOCI stuff; just looks like noise. Seems to work fine. |
|
Just made the static game speed variable atomic, as in my input branch multiple threads could end up reading it. |
leoetlino
reviewed
May 5, 2021
-Add pause state to FPSCounter. -Add ability to have more than one "OnStateChanged" callback in core. -Add GetActualEmulationSpeed() to Core. Returns 1 by default. It's used by my input PRs.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
leoetlino
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…by adding the pause state to FPSCounter.
-Add ability to have more than one "OnStateChanged" callback in core.
-Add GetActualEmulationSpeed() in Core, which will be used by input functions added by future commits (requires the new FPS counter features). It returns 1 if the emulation is not running.
Changes are actually really minor. I suggest just testing against master and seeing the problem being fixed for yourself.