Fix DualShockUDP not adding/removing devices correctly

[Filoppi]

-If adding 2 devices with the same name, their unique identifier wouldn't be increased, causing a conflict.
-Removing a device wouldn't actually remove it from the internal devices list because the local list of devices had already been updated when iterating it.
-It was possible to remove devices belonging to other input sources by adding a device with the same name and then removing it.

[Filoppi]

Huh, didn't ever imagine someone would use a duplicate device name. That's certainly not intended and probably should be enforced. But these changes look good.

I thought about enforcing it but that's not necessary given that two devices can have the exact same name under the same source, they will be distinguished by ID.

[Filoppi]

I thought about enforcing it but that's not necessary given that two devices can have the exact same name under the same source, they will be distinguished by ID.

Yeah, not a problem from a software standpoint, more from a user standpoint. Imagine you have two devices named the same thing and come back later. How do you distinguish them? I guess you have to look at the order.

More importantly, if I'm remembering right, profiles are based on device name. I wonder what would happen if it was applied. Maybe both would get it?

But like I said, it was never intended in my design, just an oversight :(

Well of course the first thing I tried to do was adding two devices with the same name to break it :).
Profiles seem to save the whole device path (e.g. DInput/0/Wireless Controller), when restoring it, if the device is not present, it will just add it back to the list and mark it as disconnected, all you got to do now is select a new default device (of the same type) and it would work, so not really a problem.
If I want to have two devices with the same name, it's my problem really, especially because if you attach two Xbox controllers, they will also have the same name, but a different ID.
I've got a PR incoming to make the input editing clearer to users, as you need a PhD to understand it as of now.

[iwubcode]

@Filoppi - sorry, I had just woken up when I looked at this initially and was thinking of the path not the actual device name. You're right, there's no reason we can't allow the same name.

This LGTM code wise (I'll test it later)

[AdmiralCurtiss]

Commits still need to be squashed.

[Filoppi]

Commits still need to be squashed.

Fixed

[Filoppi]

Fixed lint code check