Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software: Remove normalization special case #9424

Merged
merged 1 commit into from Feb 11, 2021

Conversation

@Pokechu22
Copy link
Contributor

@Pokechu22 Pokechu22 commented Jan 4, 2021

The special case doesn't appear to make a significant difference in any games, and the current implementation has a (minor, fixable) issue that breaks Super Mario Sunshine (both with a failed assertion (bug 11742) and a rendering issue (bug 7476)). Hardware testing wasn't able to reproduce the special case, either, so it may just not exist.

PR #9315 contains a fixed implementation of the special case on all video backends, and can serve as a basis for it being reintroduced if it is found to exist under more specific circumstances. For now, I don't see a reason to keep it present.

The special case doesn't appear to make a significant difference in any games, and the current implementation has a (minor, fixable) issue that breaks Super Mario Sunshine (both with a failed assertion (https://bugs.dolphin-emu.org/issues/11742) and a rendering issue (https://bugs.dolphin-emu.org/issues/7476)).  Hardware testing wasn't able to reproduce the special case, either, so it may just not exist.

PR #9315 contains a fixed implementation of the special case on all video backends, and can serve as a basis for it being reintroduced if it is found to exist under more specific circumstances.  For now, I don't see a reason to keep it present.
@dolphin-emu-bot
Copy link
Contributor

@dolphin-emu-bot dolphin-emu-bot commented Jan 4, 2021

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • rs3-bumpmapping on sw-lin-mesa: diff
  • sms-water on sw-lin-mesa: diff

automated-fifoci-reporter

@leoetlino
Copy link
Member

@leoetlino leoetlino commented Jan 28, 2021

Since hardware testing has been done and the FifoCI diff looks sane, I plan to merge this tomorrow unless somebody objects.

@nyanpasu64
Copy link
Contributor

@nyanpasu64 nyanpasu64 commented Feb 7, 2021

Still not merged? 🤔

@leoetlino leoetlino merged commit a354814 into dolphin-emu:master Feb 11, 2021
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants