Use GX_CMD_UNKNOWN_METRICS instead of magic number 0x44 #9437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Defined to be 0x44 here:
dolphin/Source/Core/VideoCommon/OpcodeDecoding.h
Line 30 in 79a234e
and already used in OpcodeDecoding here:
dolphin/Source/Core/VideoCommon/OpcodeDecoding.cpp
Lines 202 to 206 in 79a234e
That log message also has a 0x44 in it, but since it seems like the exact purpose of this command is unknown, I think it's fine to leave it like that. On the other hand, the code uses in both
FifoAnalyzer.cpps are a situation where we want0x44to match the name, especially if the name is later changed.