Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GX_CMD_UNKNOWN_METRICS instead of magic number 0x44 #9437

Merged
merged 1 commit into from Jan 12, 2021

Conversation

Pokechu22
Copy link
Contributor

Defined to be 0x44 here:

GX_CMD_UNKNOWN_METRICS = 0x44,

and already used in OpcodeDecoding here:

case GX_CMD_UNKNOWN_METRICS: // zelda 4 swords calls it and checks the metrics registers after
// that
total_cycles += 6;
DEBUG_LOG_FMT(VIDEO, "GX 0x44: {:08x}", cmd_byte);
break;

That log message also has a 0x44 in it, but since it seems like the exact purpose of this command is unknown, I think it's fine to leave it like that. On the other hand, the code uses in both FifoAnalyzer.cpps are a situation where we want 0x44 to match the name, especially if the name is later changed.

@lioncash lioncash merged commit 7fdd4af into dolphin-emu:master Jan 12, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants