New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Opacity settings for touchscreen controls #9439
Conversation
|
Fixed a small typo in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a feature we could use. Some review comments, though:
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/overlay/InputOverlay.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made all the necessary changes based off the suggestions/advice from JosJuice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits into one. We prefer to not have the git history contain little commits that fix problems that were made earlier in the same pull request.
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/overlay/InputOverlay.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/overlay/InputOverlay.java
Outdated
Show resolved
Hide resolved
|
So I made the buttons that are used in the on-screen controls. Once this is merged, I'll make a PR to replace the preset transparency on screen buttons with opaque versions, and then we can just tune this feature for setting default opacity. However, I'm not sure when I should do it? Like, I can set up a PR with the file changes, but I don't know how to set the default opacities. So either someone could help me with it, or someone could make an additional PR after mine to set it. Also I could make the PR with opaque versions of the buttons now and this PR could set the default opacities, if everyone wants to coordinate like that. |
|
The default opacity is set by this line in IntSetting.java: It's currently set to 50 in this PR, meaning 50%. We shouldn't merge a PR that makes the button image files opaque before merging this PR, but I'm fine with either doing it in the other order or doing it all in one PR. |
|
Oh, that looks pretty easy. If you prefer I adjust that in my PR then that's totally fine. I'll bug JMC to test it for me. :P 50% of the already transparent buttons would be VERY transparent! I'd be a little alarmed if that was going to stay as is, but I can just adjust it myself in my PR later. |
|
I don't think I have any remaining review comments, but you still need to squash the commits into one. |
Added Opacity controls for the user to customize the opacity of their touchscreen controls. Also, placed both Scale and Opacity settings into one window/option called Adjust Controls.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Added Opacity controls for the user to customize the opacity level of their touchscreen controls. Also, placed both Scale and Opacity settings into one window/option called Adjust Controls.