DolphinQt: Qt 6.0 forward-compatibility changes #9440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This literal was deprecated in 5.14.0. Not to mention it wasn't documented as part of the API either: see the 5.14.0 changelog here: https://code.qt.io/cgit/qt/qtbase.git/tree/dist/changes-5.14.0?h=v5.14.0 On Qt 6.0 this define is removed entirely. To stay forward compatible, we can make use of QStringLiteral instead.
An indirect inclusion scenario that breaks on Qt 6.0
Qt 5.0 introduced QRegularExpression to replace QRegExp. In Qt 6.0, QRegExp is removed entirely in favor of it.
This function has been marked as obsolete. In Qt 6.0 it's removed entirely, so we must use getContentsMargin() explicitly instead (margin() would do this for us). Ditto for setMargin(), in which case we use setContentsMargin instead. setMargin() would just pass its argument to all four parameters of setContentsMargin(), so we can do the same.
These have been replaced with setSecsSinceEpoch() and toSecsSinceEpoch(), respectively within Qt 5.8, so we can migrate over to them.
BhaaLseN
approved these changes
Jan 13, 2021
iwubcode
approved these changes
Jan 14, 2021
|
@RinMaru GitHub is a developer platform. If you wish to "discuss" Dolphin changes, go to the dolphin emulator forums: https://forums.dolphin-emu.org/Forum-development-discussion or IRC #dolphin-emu @ irc.freenode.net QT framework changes should not affect any visual elements. There are rare cases where a legacy QT feature is used then removed with no replacement where the developers would have to implement a "from scratch" equivalent but this replacement would be on the backend behind the visual elements so it would only (possibly) affect animations \ menu transitions \ etc... not the actual visual appearance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Makes changes that should ease us into transitioning over to Qt 6.0 in the future. Qt 6 brings a few breaking changes with it, and thankfully, replacements for most of those deprecated or removed features were introduced within Qt 5, so we can replace those obsoleted features.
This way when we move to Qt 6, way less things will break due to APIs being removed or changed.