TraversalProto: Minor cleanup #9455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
traversal
branch
2 times, most recently
from
230f433
to
89a8a80
Compare
iwubcode
approved these changes
Jan 20, 2021
BhaaLseN
approved these changes
Jan 20, 2021
| printf("-> %d %llu %s\n", ((TraversalPacket*)buffer)->type, | ||
| (long long)((TraversalPacket*)buffer)->requestId, SenderName(addr)); | ||
| const auto* packet = static_cast<const TraversalPacket*>(buffer); | ||
| printf("-> %d %llu %s\n", static_cast<int>(packet->type), |
There was a problem hiding this comment.
I wonder if "replace printf with a xxxx_LOG statement" falls under "minor cleanup" - but that certainly shouldn't block this or anything. Especially when the Log Statement could get rid of the #if DEBUG (unless it means something significant for performance)
Prevents implicit conversions and prevents identifiers from polluting the class scope.
Makes for strong typing and prevents namespace pollution.
Same behavior, less code.
Same behavior, more straightforward reading.
…NetAddress Previously, eaddr would only be partially initialized in the ipv6 case. Even if there's no support for it, we may as well ensure that the variable always has deterministic initialization. While we're at it, we can make the parameter a const reference, given no members are modified.
Same behavior, but allows the use of non-allocating string types with the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Mainly consists of converting enums over to
enum classto prevent implicit conversions and namespace pollution, along with converting typedefs into using aliases.