Fixed bug introduced in PR#803 caused by casting #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed casts to C++ style casts to removed some of the ambiguity.
|
@dolphin-emu-bot rebuild |
shuffle2
added a commit
that referenced
this pull request
Sep 3, 2014
Fixed bug introduced in PR#803 caused by casting
|
The problem with Android and the joysticks is still not resolved. Seems like something is still wrong, but I don't know what. I'm puzzled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also changed casts to C++ style casts to removed some of the ambiguity.
PR#803
Sorry about introducing this bug. Hopefully this fixes it correctly. The original code had one of the addends being promoted to a double. This means it could have been negative. My original change removed the possibility for this addend to be negative, introducing the bug. This fix also doesn't introduce any warnings on VS2013, but I haven't had a chance to check it on Linux.
I also took this opportunity to change the casts to C++ style casts on archshift's recommendation.