DolphinQt: Move gamecube controller ui logic to its own widget #9467
+246
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
commented
Jan 23, 2021
| } | ||
| m_gc_box->setLayout(m_gc_layout); | ||
|
|
||
| auto* layout = new QVBoxLayout; |
There was a problem hiding this comment.
This layout block is the only difference from the current code
iwubcode
force-pushed
the
gamecube_controllers_widget
branch
from
1eb2858
to
780360b
Compare
|
@leoetlino - this one should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pulled from #8823 to make it easier to merge
Should have no functional or visual changes