DolphinQt: Move wiimote controller ui logic to its own widget #9468
+413
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
wiimote_controllers_widget
branch
from
0380647
to
9ef28d0
Compare
iwubcode
commented
Jan 23, 2021
| m_wiimote_layout->addWidget(m_wiimote_continuous_scanning, continuous_scanning_row, 0, 1, 3); | ||
| m_wiimote_layout->addWidget(m_wiimote_refresh, continuous_scanning_row, 3); | ||
|
|
||
| auto* layout = new QVBoxLayout; |
There was a problem hiding this comment.
This layout block is the only difference from the current code
|
Not sure making those commits/PRs at the same time was a good idea because of conflicts :P This needs to be rebased now that #9466 has been merged. |
iwubcode
force-pushed
the
wiimote_controllers_widget
branch
from
9ef28d0
to
4d1252e
Compare
iwubcode
force-pushed
the
wiimote_controllers_widget
branch
from
4d1252e
to
f3b6c97
Compare
|
Probably not, haha! Updated @leoetlino , thanks! I'll clean up #9467 after this is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pulled from #8823 to make it easier to merge
Should have no functional or visual changes