msbuild: re-enable HAS_OPENGL and HAS_VULKAN #9479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the OpenGL condition correct? If I'm reading this correctly, HAS_OPENGL will only be enabled when the platform is not ARM64, however, nowadays Dolphin can be built for Windows 10 ARM and AFAICT it has OpenGL support... |
|
I don't test ARM so I can't say but if we update this, this cmake can be updated as well (and comment removed): https://github.com/dolphin-emu/dolphin/blob/master/CMakeLists.txt#L554 |
|
windows on arm does not natively support (full) opengl. There is a (just released) translation layer https://devblogs.microsoft.com/directx/announcing-the-opencl-and-opengl-compatibility-pack-for-windows-10-on-arm/ but I don't forsee dolphin wanting to use that, really... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fixes regression from #9092