JitArm64: Use STP for (parts of) ppcState.ps #9484
Merged
+55
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The savestate incompatibility problem mentioned in a comment was solved by d266be5.
JosJuice
force-pushed
the
jitarm64-ps-stp
branch
from
34e675a
to
91b5582
Compare
leoetlino
approved these changes
Jan 30, 2021
| m_emit->STP(IndexType::Signed, RX1, RX2, PPC_REG, u32(ppc_offset)); | ||
| if (!maintain_state) | ||
| const size_t ppc_offset = GetGuestByIndex(i).ppc_offset; | ||
| if (ppc_offset <= 252) |
There was a problem hiding this comment.
Just checking: it's 252 here because it's a 32-bit STP, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The savestate incompatibility problem mentioned in a comment was solved by PR #4687.