InputCommon: fix potential dynamic input texture crash and an optimization #9488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Feb 11, 2021
…ntial crash that can occur by multiple threads touching a single resource
…d textures once for packs that have multiple configurations
iwubcode
force-pushed
the
dynamic-input-tex-optimizations
branch
from
d9e1ff4
to
ce7db2e
Compare
|
@leoetlino - done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There was the possibility that a dynamic input texture change would cause a reload of textures while the prefetcher was sorting through them. This would cause a crash.
Also for packs with multiple configurations, we were calling force reload too many times