Config: Fix expression window scroll wheel spam #9490
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the expression window being spammed with the first entry in the Operators or Functions select menus when scrolling the mouse wheel while hovering over them. Fixes https://bugs.dolphin-emu.org/issues/12405
Dentomologist
force-pushed
the
fix_expression_scroll_wheel_spam
branch
from
f045e80
to
43b3894
Compare
|
I just added a small change to pass a parent pointer to m_functions_combo to match prior behavior. Speaking of which, this is out of scope for this PR but IOWindow seems very inconsistent about which children get passed parent pointers and which don't. Is there a reason I'm missing for the current pattern or is that something that should be fixed at some point? |
leoetlino
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes the expression window being spammed with the first entry in the
Operators or Functions select menus when scrolling the mouse wheel while
hovering over them.
Fixes https://bugs.dolphin-emu.org/issues/12405