PCAP: Add raw SSL packets logging support #9499
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that #9408 has been merged, this PR needs a rebase. |
sepalani
force-pushed
the
pcap-ssl-raw
branch
2 times, most recently
from
6a4cec9
to
47defef
Compare
|
@leoetlino |
leoetlino
requested changes
Feb 14, 2021
sepalani
force-pushed
the
pcap-ssl-raw
branch
from
47defef
to
d3dd830
Compare
|
@leoetlino |
leoetlino
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR allows the NetworkLogger to dump raw SSL packets in PCAP format when dumping decrypted SSL packets is disabled.
That way, most network related features would be supported by the logger except for WiiConnect24, DNS and ICMP packets.
Ready to be reviewed & merged.
Depends on #9408.