Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidapi: Use LIBUSB_LIBRARIES to link to libusb #9501

Merged
merged 1 commit into from Feb 12, 2021

Conversation

leoetlino
Copy link
Member

Because we have an old-style find script that does not define a proper
CMake target for libusb, we need to use ${LIBUSB_LIBRARIES}
rather than "usb".

Ideally, we would fix the find script to define a target. However,
this issue breaks the fifoci-ogl-lin-mesa builder and I'd prefer it
to be fixed sooner rather than later.

Because we have an old-style find script that does not define a proper
CMake target for libusb, we need to use ${LIBUSB_LIBRARIES}
rather than "usb".

Ideally, we would fix the find script to define a target. However,
this issue breaks the fifoci-ogl-lin-mesa builder and I'd prefer it
to be fixed sooner rather than later.
@iwubcode
Copy link
Contributor

Because we have an old-style find script that does not define a proper
CMake target for libusb, we need to use ${LIBUSB_LIBRARIES}
rather than "usb".

I'm fairly familiar with CMake but I don't know much about Dolphin's build system. I didn't realize we were exposing these to the find functionality. I assumed the add_library like defined here was good enough. Where do expose these external's to CMake's search path?

@leoetlino
Copy link
Member Author

The issue isn't in our Externals CMakeLists.txt, but in FindLibUSB.cmake, which doesn't define a real CMake target.

Copy link
Contributor

@merryhime merryhime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally, thanks (for reference the target is a stripped down AArch64 machine without libusb)

@leoetlino leoetlino merged commit c5ee86c into dolphin-emu:master Feb 12, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants