InputCommon: move some dynamic input texture logic and add specification option #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
dynamic_input_textures_improved
branch
4 times, most recently
from
1a9778e
to
9d68264
Compare
|
@leoetlino - thanks for your comment on IRC. I would have never thought of the name clash! I updated the names, it's a little redundant I guess but I wanted to keep the namespace. |
leoetlino
reviewed
Feb 16, 2021
iwubcode
force-pushed
the
dynamic_input_textures_improved
branch
from
9d68264
to
305f4a7
Compare
|
Thanks @leoetlino . I agree with the request, just didn't know if the filename and class name needed to match. Anyway, fixed up all the classes. |
leoetlino
reviewed
Feb 18, 2021
Source/Core/InputCommon/DynamicInputTextures/DITConfiguration.cpp
Outdated
Show resolved
Hide resolved
iwubcode
force-pushed
the
dynamic_input_textures_improved
branch
from
305f4a7
to
47dcb6e
Compare
leoetlino
reviewed
Feb 19, 2021
Source/Core/InputCommon/DynamicInputTextures/DITSpecification.cpp
Outdated
Show resolved
Hide resolved
…o a 'specification 1' function and load in a 'specification' attribute that defaults to 1 if not present (with 1 being the only valid value at the moment)
iwubcode
force-pushed
the
dynamic_input_textures_improved
branch
from
47dcb6e
to
55ba1c7
Compare
leoetlino
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This will come across as a big change but really I'm just moving some code around and adding a "specification" option in json, so that I can add a new set of features in a future PR.