Debugger: Fix issue were loaded memory breakpoints were not being triggered (break) #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused, because we were saving the `break_on_hit` flag with the letter `p`. Then while loading the breakpoints, we read the flag with the letter `b`, resulting in the `break_on_hit` flag being always false
sepalani
approved these changes
Feb 20, 2021
|
Is... there a reason this is stored in a string instead of, like, a struct or a bitfield? |
|
Probably because they are saved to and loaded from an INI file. |
|
I feel like this should be changed to not a string with magic letters at some point, but this is free to merge in the meantime IMO. |
AdmiralCurtiss
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This was caused, because we were saving the
break_on_hitflag with the letterp. Then while loading the breakpoints, we read the flag with the letterb, resulting in thebreak_on_hitflag being always false.