WatchWidget: Add new/delete/clear toolbar items #9527
Merged
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Feb 21, 2021
| @@ -111,6 +118,10 @@ void WatchWidget::ConnectWidgets() | |||
|
|
|||
| void WatchWidget::UpdateIcons() | |||
| { | |||
| // TODO: Create a "debugger_add_watch" icon | |||
There was a problem hiding this comment.
Who would create this? How do we keep track of this other than a code "TODO"? Maybe an issue in the issue tracker? I have some icons needed too..
There was a problem hiding this comment.
@MayImilae would be the person to talk to.
There was a problem hiding this comment.
@JosJuice - is there a way we can track this or must we block this PR until MayImilae has time to create said icons?
There was a problem hiding this comment.
I don't think we really have a standard way to track icon requests... But I suppose the issue tracker could make sense.
|
May said she doesn't have time to work on an icon right now, so I think it is fine to merge it without one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds to the Watch widget toolbar items to create, delete and clear watches.
Ready to reviewed & merged.