Android: Broadcast update before updating additional metadata #9529
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
approved these changes
Mar 4, 2021
In master, the game scanning process looks like this: 1. Scan for games 2. Scan for additional metadata (icon.png and meta.xml) 3. Save the cache if needed 4. Update the game list with the results This change makes the game scanning process look like this: 1. Scan for games 2. Update the game list with the results 3. Scan for additional metadata (icon.png and meta.xml) 4. Update the game list with the results 5. Save the cache if needed Updating the game list as soon as possible means the user has to wait less before their games show up. The new behavior matches what DolphinWX did before it was removed. (DolphinQt has an even fancier approach where games get added one by one.)
JosJuice
force-pushed
the
android-broadcast-before-metadata
branch
from
53e6ab7
to
873d5f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In master, the game scanning process looks like this:
This change makes the game scanning process look like this:
Updating the game list as soon as possible means the user has to wait less before their games show up. The new behavior matches what DolphinWX did before it was removed. (DolphinQt has an even fancier approach where games get added one by one.)