BreakpointWidget: Fix delete deleting both MBP and BP at address #9564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
requested changes
Mar 4, 2021
| Settings::Instance().blockSignals(false); | ||
| if (is_memcheck) | ||
| { | ||
| Settings::Instance().blockSignals(true); |
There was a problem hiding this comment.
I realise this was already written like this, but using a QSignalBlocker would be cleaner here. Idea for a follow-up PR :)
|
@leoetlino |
leoetlino
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes the delete action which deletes everything matching the address of the selected item (i.e. both memory and regular breakpoints).
Ready to be reviewed & merged.