[Updater] Check whether we've already had an update triggered #9580
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
approved these changes
Mar 16, 2021
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| namespace | |||
| { | |||
| bool s_update_triggered = false; | |||
There was a problem hiding this comment.
(I was trying to see if we could avoid adding static state, but I guess spawning a process is modifying system global state anyway...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently Dolphin just assumes that it only has one update running, if a user were to "accidentally" check for updates, check the "Update when dolphin closes" checkbox multiple times then closes dolphin, you get a ton of updaters running at once.
The solution is to only ever allow dolphin to trigger the update once then wait for dolphin to close.