Expose Control Expression variables to mappings UI #9581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
force-pushed
the
expose_input_expr_vars
branch
from
047d08e
to
e75e6b9
Compare
lioncash
reviewed
Mar 12, 2021
Filoppi
force-pushed
the
expose_input_expr_vars
branch
from
9bddedb
to
7b526e0
Compare
Filoppi
force-pushed
the
expose_input_expr_vars
branch
from
7b526e0
to
c6e4cc4
Compare
|
@dolphin-emu-bot rebuild |
JMC47
reviewed
May 23, 2021
Filoppi
force-pushed
the
expose_input_expr_vars
branch
from
c6e4cc4
to
5509372
Compare
Fixed all. |
Filoppi
force-pushed
the
expose_input_expr_vars
branch
2 times, most recently
from
7b17e7e
to
906cd51
Compare
JMC47
approved these changes
May 23, 2021
-add a way to reset their value (from the mappings UI) -fix "memory leak" where they would never be cleaned, one would be created every time you wrote a character after a "$" -fix ability to create variables with an empty string by just writing "$" (+added error for it) -Add $ operator to the UI operators list, to expose this functionality even more
Filoppi
force-pushed
the
expose_input_expr_vars
branch
from
906cd51
to
93e3e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
-add a way to reset their value (from the mappings UI)
-fix "memory leak" where they would never be cleaned, one would be created every time you wrote a character after a "$"
-fix ability to create variables with an empty string by just writing "$" (+ added a parsing error for the case)
-add $ operator to the UI operators list, to expose this functionality even more
The UI will now show all the custom variables used.
Their value is kept as long as there is at least one mapping (control expression) referencing them. You can ever change devices or input profile and as long as the variable was and is still referenced, the value will be kept.
Still, the ability to reset values without restarting Dolphin or being forced to change their names can be useful.
UI is always kept to date with the actual values underneath.
The control ref variables were a bit obscure and confusing and hidden away from users, so this should also help with making them aware of the feature.
Tested everything. There should be no negative consequences to this.
Pic is from my work branch, but you can understand what changed:
