SI/DeviceGBA: Improve link stability #9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes connecting to Final Fantasy: Crystal Chronicles. |
BhaaLseN
reviewed
Mar 13, 2021
| @@ -258,12 +261,12 @@ int GBASockServer::Receive(u8* si_buffer, u8 bytes) | |||
| if (!m_client) | |||
| return 0; | |||
|
|
|||
| sf::SocketSelector selector; | |||
| selector.add(*m_client); | |||
| if (m_booted) | |||
There was a problem hiding this comment.
I wonder if its worth documenting why m_booted affects how long we can/should wait for a socket, and if those numbers have any significance (vs. being guesses that just work in practise)
There was a problem hiding this comment.
Apparently the number didn't even work on Windows, so I replaced it with redefining what m_booted represents.
|
This does improve linking with Final Fantasy: Crystal Chronicles. I do not know of any regressions. |
BhaaLseN
approved these changes
Mar 22, 2021
|
I know I've been testing it and I think @JMC47 has been too, so "untested" might not be the most accurate description here. |
|
Untested by me ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Building on #9550 I found some more issues that could cause the link to get out of sync.
The original flush technique didn't work properly; it didn't work before the first RESET was sent, which generally meant the first RESET would be junk too. This replaces it with flushing before sending any message. This approach isn't perfect but clears out the junk much more reliably.
This also adds a minor wait for the "non-booted" state (polling for status instead of actual data transfer) to improve the stability further.