JitArm64: Skip calculating carry flag when not needed #9585
Conversation
|
Actually... I was assuming that this would make these instructions complete faster on some CPUs, but now that I look, I can't find any specific CPUs where they would complete faster. Should we do this anyway? |
JosJuice
force-pushed
the
jitarm64-skip-carry
branch
from
d2c1906
to
26ed048
Compare
|
Even if this has no effect on the execution units performance, it might have one on the out-of-order decoder. So yes, I think it is good not to write any state which we don't need. |
JosJuice
force-pushed
the
jitarm64-skip-carry
branch
from
26ed048
to
baecddd
Compare
| @@ -16,6 +16,15 @@ | |||
|
|
|||
| using namespace Arm64Gen; | |||
|
|
|||
| #define CARRY_IF_NEEDED(inst_without_carry, inst_with_carry, ...) \ | |||
There was a problem hiding this comment.
Is this not able to be made into a templated member function of JitArm64?
There was a problem hiding this comment.
It would be rather annoying, because most of the functions we want to pass as the first two arguments are overloaded, and I'm not aware of any way that a templated function would be able to determine the correct overload without the caller having to explicitly specify the intended overload.
No description provided.