CMake: Fix unused compiler flag warning #9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
force-pushed
the
fix_no_objc_exceptions_warning
branch
from
495de54
to
b8db40e
Compare
Add a check to define FMT_EXCEPTIONS = 0 when compiling on MacOS. Replaces -fno-objc-exceptions, which also disabled fmt exceptions but generated warnings when compiling c++ files.
Dentomologist
force-pushed
the
fix_no_objc_exceptions_warning
branch
from
b8db40e
to
7eaa98d
Compare
leoetlino
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add a check to define FMT_EXCEPTIONS = 0 when compiling on MacOS.
Replaces -fno-objc-exceptions, which also disabled fmt exceptions but generated warnings when compiling c++ files.