Android: Fix rescanning on first app launch after cache clear #9592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GameFileCacheService.startRescan (in MainPresenter.onResume) does nothing if called before GameFileCacheService.startLoad. Fixes a 3f71c36 regression where already added games would not show up after app launch under specific circumstances. Unfortunately the loading indicator still doesn't show up during a rescan initiated by app launch, but that would be more annoying to fix, so I will leave it for now.
lioncash
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
GameFileCacheService.startRescan (in MainPresenter.onResume) does nothing if called before GameFileCacheService.startLoad. Fixes a PR #9569 regression where already added games would not show up after app launch under specific circumstances.
Unfortunately the loading indicator still doesn't show up during a rescan initiated by app launch, but that would be more annoying to fix, so I will leave it for now.