VertexLoaderTest: Fix memset assignment warning #9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize and assign members of TVtxDesc and VAT structs directly instead of using memset. Fixes -Wclass-memaccess warning from gcc on Debian.
Dentomologist
force-pushed
the
fix_vertex_loader_test_warnings
branch
from
0e96e1b
to
1cc035e
Compare
|
As an alternative to specifying default values in CPMemory.h, this seems to be valid (but is much more awkward looking than when used for single structs): TVtxDesc vtx_desc{.low{.Hex = 0}, .high{.Hex = 0}};
VAT vat{.g0{.Hex = 0}, .g1{.Hex = 0}, .g2{.Hex = 0}}; |
lioncash
reviewed
Mar 22, 2021
| m_vtx_desc.low.Hex = 0; | ||
| m_vtx_desc.high.Hex = 0; | ||
|
|
||
| m_vtx_attr.g0.Hex = 0; |
There was a problem hiding this comment.
This can be shortened to:
Suggested change
| m_vtx_attr.g0.Hex = 0; | |
| m_vtx_attr = {}; |
There was a problem hiding this comment.
This doesn't work because the copy assignment operator for BitField has been deleted.
I tried creating a copy assignment operator for TVtxDesc and VAT to copy the respective member .Hex fields, but kept getting errors (I believe from the BitFieldArrays in TVtxDesc .low and .high) about the operation not being sane.
| @@ -50,8 +48,12 @@ class VertexLoaderTest : public testing::Test | |||
| memset(input_memory, 0, sizeof(input_memory)); | |||
| memset(output_memory, 0xFF, sizeof(input_memory)); | |||
|
|
|||
| memset(&m_vtx_desc, 0, sizeof(m_vtx_desc)); | |||
| memset(&m_vtx_attr, 0, sizeof(m_vtx_attr)); | |||
| m_vtx_desc.low.Hex = 0; | |||
There was a problem hiding this comment.
This can be shortened to:
Suggested change
| m_vtx_desc.low.Hex = 0; | |
| m_vtx_desc = {}; |
Dentomologist
force-pushed
the
fix_vertex_loader_test_warnings
branch
2 times, most recently
from
e3140d0
to
1cc035e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Testing a fix for Debian unit test warning -Wclass-memaccess.