Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply More Core::RunAsCPUThread #9596

Merged
merged 1 commit into from Mar 27, 2021

Conversation

Minty-Meeo
Copy link
Member

In places where applicable, Core::RunAsCPUThread has replaced Core::SetState workarounds to pause and resume emulation for thread-sensitive operations.

  • void Core::SaveScreenShot()
  • void Core::SaveScreenShot(std::string_view name)
  • void JitInterface::GetProfileResults(Profiler::ProfileStats *prof_stats)
  • void MainWindow::OnExportRecording()

In places where applicable, Core::RunAsCPUThread has replaced Core::SetState workarounds to pause and resume emulation for thread-sensitive operations.
 - void Core::SaveScreenShot()
 - void Core::SaveScreenShot(std::string_view name)
 - void JitInterface::GetProfileResults(Profiler::ProfileStats *prof_stats)
 - void MainWindow::OnExportRecording()
@Rumi-Larry
Copy link

Does this pr depend on #9361 or viceversa? They seem independent of each other.

@Minty-Meeo
Copy link
Member Author

Minty-Meeo commented Mar 20, 2021

Does this pr depend on #9361 or viceversa? They seem independent of each other.

This PR is independent. I came up with some unrelated minor improvements while working on PR #9361, and it was suggested I put them in a separate PR for tidiness.

@leoetlino leoetlino merged commit c915b78 into dolphin-emu:master Mar 27, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants