AudioCommon: Split Initialization #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps it would be good to leave a comment about why |
|
LGTM, aside from Jos' remark. |
BhaaLseN
reviewed
Mar 22, 2021
|
|
||
| void PostInitSoundStream() | ||
| { | ||
| // This needs to be called after HW::Init where input sample rates are set |
There was a problem hiding this comment.
This should probably mention AudioInterface::Init, should it? HW::Init isn't wrong (because it calls AudioInterface::Init), but it should only be a secondary mention due to the connection in EmuThread.
Thoughts?
There was a problem hiding this comment.
I didnt want to be too specific about AudioInterface::Init since #9600 also takes advantage of this which would make the comment no longer correct, so I guess I'll just update the comment in that PR as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This splits SoundStream initialization in two parts, allowing HW::Init to set sample rates and addresses a comment that's been around for a while