Qt: avoid queuing ConfigChanged() more than once #9606
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Mar 24, 2021
Filoppi
force-pushed
the
patch-14
branch
2 times, most recently
from
e97362b
to
0dc545c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This often happens when changing certain settings and starting/stopping a game and it's just a waste.
I'm not even sure how safe it is to not call "OnConfigChanged()" inline when editing settings from the Qt UI with a cursor, given that a lot of widgets states are refreshed within that callback. But I guess a user couldn't interact with two widgets before Qt had actually run its next update and called that queued callback.