Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shortcut creation #9610

Merged
merged 2 commits into from Mar 30, 2021
Merged

Fix shortcut creation #9610

merged 2 commits into from Mar 30, 2021

Conversation

CookiePLMonster
Copy link
Contributor

@CookiePLMonster CookiePLMonster commented Mar 27, 2021 •
edited

This PR fixes the following:

  1. Selected shortcut names did not use the Title Database, making them inconsistent with Dolphin's game list and sometimes picking rather unfortunate names, depending on game's metadata.
  2. Shortcuts of games containing invalid NTFS characters in their name (most commonly :) would create incorrectly. These characters are now being removed from the file name.

@CookiePLMonster
GameList: Remove invalid characters when creating a desktop shortcut
0fb8f73 
Fixes shortcut creation for games that have e.g. : in names.
@CookiePLMonster
GameList: Use titles from the Title Database for shortcut creation
d4b7ed4 
Makes titles consistent with Dolphin's game list
@leoetlino leoetlino merged commit 06439a2 into dolphin-emu:master Mar 30, 2021
10 checks passed
@CookiePLMonster CookiePLMonster deleted the fix-shortcut-creation branch March 30, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash left review comments

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@CookiePLMonster @lioncash @leoetlino