Android: Rename "Enable Logging" to "Write Logs to File" #9612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option does in fact not enable and disable logging as a whole. You can get logs through logcat regardless of this setting. Also taking the opportunity to remove the reference to the "dolphin-emu" folder name since we will no longer be using that folder once scoped storage is applied to Dolphin.
lioncash
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This option does in fact not enable and disable logging as a whole. You can get logs through logcat regardless of this setting.
Also taking the opportunity to remove the reference to the "dolphin-emu" folder name since we will no longer be using that folder once scoped storage is applied to Dolphin.