Android: Expand the game INI deletion prompt #9613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PR 8203 for background on the game INI deletion prompt. It's been almost two years since PR 8203 was merged, so you would think that people are no longer creating game INIs that contain a copy of every global setting, right? Unfortunately, MMJ was forked not too long before that and never backported the change, so right now there's a not insignificant number of people online posting game INIs full of this garbage for others to use. One thing that's been missing from the game INI deletion prompt is a description of what the problem with having tons of extra lines in a game INI actually is. This change adds that, in the the hope that it will make people ignore the warning less often.
lioncash
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See PR #8203 for background on the game INI deletion prompt.
It's been almost two years since PR #8203 was merged, so you would think that people are no longer creating game INIs that contain a copy of every global setting, right? Unfortunately, MMJ was forked not too long before that and never backported the change, so right now there's a not insignificant number of people online posting game INIs full of this garbage for others to use.
One thing that's been missing from the game INI deletion prompt is a description of what the problem with having tons of extra lines in a game INI actually is. This change adds that, in the the hope that it will make people ignore the warning less often.