Android: Add "Synchronize GPU Thread" setting (SyncOnSkipIdle/SyncGPU) #9614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many Android users want to disable SyncOnSkipIdle as a performance hack, to the point where it's often suggested as something to paste into Dolphin.ini (if not to use a fork). If adding it as a setting in the GUI gives us an opportunity to explain what the setting actually does and stops people from pasting stuff they don't understand into INI files, I think it can be worth adding despite how it can make games unstable. It not being in the GUI doesn't seem to be stopping people from disabling it anyway. The added setting in the GUI is a three-way setting called "Synchronize GPU Thread" with the following alternatives: "Never": SyncGPU = False, SyncOnIdleSkip = False "On Idle Skipping": SyncGPU = False, SyncOnIdleSkip = True "Always": SyncGPU = True, SyncOnIdleSkip = True
lioncash
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Many Android users want to disable SyncOnSkipIdle as a performance hack, to the point where it's often suggested as something to paste into Dolphin.ini (if not to use a fork). If adding it as a setting in the GUI gives us an opportunity to explain what the setting actually does and stops people from pasting stuff they don't understand into INI files, I think it can be worth adding despite how it can make games unstable. It not being in the GUI doesn't seem to be stopping people from disabling it anyway.
The added setting in the GUI is a three-way setting called "Synchronize GPU Thread" with the following alternatives:
Setting description:
Synchronizing the GPU thread reduces the risk of games crashing or becoming unstable with dual core enabled, but can also reduce the performance gain of dual core. If unsure, select "On Idle Skipping". Selecting "Never" is risky and not recommended!