Convert GameList col enum to enum class #9620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
force-pushed
the
convert_gamelist_col_to_enum_class
branch
from
5346a19
to
cd088d2
Compare
Rumi-Larry
reviewed
Apr 1, 2021
Dentomologist
force-pushed
the
convert_gamelist_col_to_enum_class
branch
from
cd088d2
to
b98077b
Compare
lioncash
reviewed
Apr 2, 2021
| hor_header->setSectionResizeMode(static_cast<int>(column), mode); | ||
| }; | ||
| { | ||
| using column = GameListModel::Column; |
There was a problem hiding this comment.
Given this is a type alias, it should still be cased like This
There was a problem hiding this comment.
Pretty sure it could be just using GameListModel::Column in that case.
There was a problem hiding this comment.
Dentomologist
force-pushed
the
convert_gamelist_col_to_enum_class
branch
2 times, most recently
from
9a21353
to
f9ac26d
Compare
BhaaLseN
reviewed
Apr 2, 2021
Remove COL_ prefix and change to TitleCase
Dentomologist
force-pushed
the
convert_gamelist_col_to_enum_class
branch
from
f9ac26d
to
601dcfa
Compare
leoetlino
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also adds a couple lambdas and using directives to reduce visual noise.