Check that zstd headers can be found before using a shared zstd library #9622
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is |
Modify the CMakeLists.txt so that it doesn't try to use a shared zstd library that doesn't have header files. This was a support issue on Macs because homebrew was installing headerless zstd libraries with Qt.
skylersaleh
force-pushed
the
fix_zstd_headers
branch
from
9d3a81f
to
b0d91a5
Compare
|
@JosJuice Sorry about the embarrassing mistake, It is now defined in the commit. |
|
I assume having the headers without the library isn't possible. But if it is, then such a special case need to be handled, just in case. |
|
There's no reason to have special handling for that case. It'll go to "Shared zstd not found, falling back to the static library", which is the correct thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some users were struggling to build the Mac build of dolphin because Homebrew had installed a header-less version of the zstd library with Qt and were getting compilation errors that were difficult to track down.
This pull requests modifies the CMakeLists.txt so that it checks for header files for zstd before using the shared zstd library.