Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameini: Disable ICache for Indiana Jones and the Staff of Kings #9630

Merged
merged 1 commit into from May 13, 2021

Conversation

PatrickFerry
Copy link
Contributor

@PatrickFerry PatrickFerry commented Apr 8, 2021

The option to disable ICache is recent but it allows Indiana Jones and the Staff of Kings to proceed where it would otherwise crash.

This game got past the first loading screen and in-game in 3.0-195(1387da7), however at certain parts the game will crash. Recent logs will state that an ICache read returned stale data.

@PatrickFerry PatrickFerry changed the title GameDisable ICache Gameini Disable ICache Apr 8, 2021
@MayImilae
Copy link
Contributor

[Video_Settings]
SafeTextureCacheColorSamples = 2048

[Video_Hacks]
EFBEmulateFormatChanges = True

What is your reasoning for these two ancillary changes? You only describe the one.

@PatrickFerry
Copy link
Contributor Author

Some scenes in game are either fuzzy or have a different tint(blue) when "Ignore Format Changes" is set.

The intro screen(LucasArts) is choppy even with Texture Cache at "Medium" but a higher value makes it look correct.

@PatrickFerry PatrickFerry changed the title Gameini Disable ICache Gameini: Disable ICache Apr 8, 2021
@iwubcode
Copy link
Contributor

iwubcode commented Apr 8, 2021

@PatrickFerry - please add the game name to the title for others reference

@PatrickFerry PatrickFerry changed the title Gameini: Disable ICache Gameini: Disable ICache for Indiana Jones and the Staff of Kings Apr 8, 2021
@Pokechu22
Copy link
Contributor

Have you tested the game with the (uncached) interpreter core on master? ICache is implemented in a way that should be accurate when using the uncached interpreter so it would be good to make sure that a JIT-ICache interaction is actually at fault.

@Miksel12
Copy link
Contributor

Miksel12 commented Apr 8, 2021

The ini file is RJ8E64 only while it says RJ8P64 and RJ8E64 in the file itself. So you should rename the file to RJ8 or drop RJ8P64.

@JosJuice
Copy link
Member

JosJuice commented Apr 8, 2021

Yes, the file should be renamed to RJ8.ini.

@PatrickFerry
Copy link
Contributor Author

Have you tested the game with the (uncached) interpreter core on master? ICache is implemented in a way that should be accurate when using the uncached interpreter so it would be good to make sure that a JIT-ICache interaction is actually at fault.

It doesn't crash if uncached interpreter is used.

I also renamed the file to work for any region.

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't own this game, so I haven't tested myself, but this seems like a reasonable change to me.

Since it's a Wii game, HLE_BS2 = True isn't required (as only the GameCube Main Menu has issues with ICache being disabled), so it not being included is correct.

Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact pure interpreter works signals that this is the best we can do to fix the issue for now. All changes to the INI make sense.

@JosJuice JosJuice merged commit 099bf16 into dolphin-emu:master May 13, 2021
10 checks passed
@PatrickFerry PatrickFerry deleted the ini-fixes-2 branch May 13, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants