Build: Fix -fno-strict-aliasing on Xcode builds #9634
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode is configured by default to turn on the strict aliasing optimization through a separate project setting. This would cause the compiler to be called with both -fno-strict-aliasing and -fstrict-aliasing. This change turns off that project setting causing only the -fno-strict-aliasing flag to be provided to the compiler.
|
@dolphin-emu-bot rebuild |
|
Seems okay to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Xcode is configured by default to turn on the strict aliasing optimization through a separate project setting. This would cause the compiler to be called with both -fno-strict-aliasing(from the CMakeLists.txt) and -fstrict-aliasing(appended to the compiler arguments by Xcode) flags. This change turns off this default project setting, causing only the -fno-strict-aliasing flag to be provided to the compiler.