Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DriverDetails: Fix broken vector bitwise AND on Mali drivers #9636

Merged
merged 1 commit into from Apr 14, 2021

Conversation

lynxnb
Copy link
Member

@lynxnb lynxnb commented Apr 11, 2021

Mali GPUs have been plagued by this issue since the dawn of time of Dolphin on Android (though I'm not sure if other OSes are also affected by this). This makes Super Mario Galaxy 1 and 2 completely unplayable on those GPUs, but I'm not aware of any other game that is affected by this.

Here's the before and after:
comparison smg1

@lynxnb lynxnb force-pushed the mali-broken-and branch 2 times, most recently from def7f31 to 5aa47a7 Compare April 11, 2021 10:23
@lynxnb
Copy link
Member Author

lynxnb commented Apr 11, 2021

Fixed lint errors

@BhaaLseN
Copy link
Member

I'm afraid you didn't :)
Curlies go on the next line, specifically the one on the if.

@lynxnb
Copy link
Member Author

lynxnb commented Apr 11, 2021

Damn it
Done, should have got it right this time

@JosJuice
Copy link
Member

This line is also using a bitwise AND:

out.Write("\tint2 dither = int2(rawpos.xy) & 1;\n");

Could you check if rendering breaks on Mali when disabling Force 24-Bit Color? If not, then LGTM as it is.

@lynxnb
Copy link
Member Author

lynxnb commented Apr 13, 2021

Sure thing, will take a look.

@lynxnb
Copy link
Member Author

lynxnb commented Apr 14, 2021

I've yet to investigate the exact circumstances in which this happen, as I'm planning to report this in depth to ARM in the future. For now the issue seems to be related to certain ivec4 only, as ANDing ivec3 and lower components count vectors results in the correct behavior.
Disabling Force 24-Bit Color has no effect on rendering.

@JMC47 JMC47 merged commit 14959a1 into dolphin-emu:master Apr 14, 2021
10 checks passed
@lynxnb lynxnb deleted the mali-broken-and branch June 3, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants