New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DriverDetails: Fix broken vector bitwise AND on Mali drivers #9636
Conversation
def7f31
to
5aa47a7
Compare
|
Fixed lint errors |
|
I'm afraid you didn't :) |
|
Damn it |
|
This line is also using a bitwise AND:
Could you check if rendering breaks on Mali when disabling Force 24-Bit Color? If not, then LGTM as it is. |
|
Sure thing, will take a look. |
|
I've yet to investigate the exact circumstances in which this happen, as I'm planning to report this in depth to ARM in the future. For now the issue seems to be related to certain ivec4 only, as ANDing ivec3 and lower components count vectors results in the correct behavior. |
Mali GPUs have been plagued by this issue since the dawn of time of Dolphin on Android (though I'm not sure if other OSes are also affected by this). This makes Super Mario Galaxy 1 and 2 completely unplayable on those GPUs, but I'm not aware of any other game that is affected by this.
Here's the before and after:
