Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JitArm64: Implement FPRF updates #9637

Merged
merged 3 commits into from May 13, 2021
Merged

JitArm64: Implement FPRF updates #9637

merged 3 commits into from May 13, 2021

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Apr 11, 2021 •
edited

No description provided.

@JosJuice JosJuice force-pushed the jitarm64-fprf branch 2 times, most recently from 62cb39c to 86fd6a2 Compare April 12, 2021 14:09
@JosJuice JosJuice marked this pull request as ready for review April 12, 2021 14:09
@JMC47
Copy link
Contributor

JMC47 commented Apr 23, 2021

Improves framerate of F-Zero GX for me.

Opening/Loading -> 48 FPS to 60 FPS
Aeropolis - Screw Drive -> 28 FPS to 38 FPS (rolling average on a lap)
Mute City -> 38 FPS -> 45 FPS

Tested in practice mode to remove the RNG from AI cars. Note that practice mode wasn't actually significantly faster than races, just more stable.

@JMC47
Copy link
Contributor

JMC47 commented Apr 23, 2021

Completely removes all lag from Super Monkey Ball on my phone. Goes from 52- 55 FPS in bigger levels to completely full speed.

@JMC47
Copy link
Contributor

JMC47 commented Apr 23, 2021

All of the FPRF games appear to work.

Rumi-Larry
Rumi-Larry reviewed Apr 25, 2021
View reviewed changes
Source/Core/Common/Arm64Emitter.cpp Outdated

ASSERT_MSG(DYNA_REC, !top || IsQuad(fpr), "FMOV: top can only be used with quads");

// Should this check be more lenient? Sometimes you do want to do things like
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really seems like a TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is that type of comment.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, then placing "TODO:" before the comment would make it easier to recognize as such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was fine like this, but alright, I've added "TODO:" in front of it.

@JosJuice JosJuice force-pushed the jitarm64-fprf branch 3 times, most recently from dfebc88 to 4aec700 Compare May 5, 2021 17:39
degasus
degasus approved these changes May 12, 2021
View reviewed changes
Source/Core/Core/PowerPC/JitArm64/JitAsm.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/JitArm64/JitAsm.cpp Outdated Show resolved Hide resolved
Source/UnitTests/Core/PowerPC/JitArm64/FPRF.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/JitArm64/JitAsm.cpp Outdated Show resolved Hide resolved
@degasus
Copy link
Member

degasus commented May 13, 2021

LGTM

@lioncash lioncash merged commit 725ea3d into dolphin-emu:master May 13, 2021
10 of 11 checks passed
@JosJuice JosJuice deleted the jitarm64-fprf branch May 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degasus degasus degasus approved these changes

@Rumi-Larry Rumi-Larry Rumi-Larry left review comments

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@JosJuice @JMC47 @degasus @lioncash @Rumi-Larry @shuffle2